Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile with Ivy #78

Merged
merged 11 commits into from
Jan 16, 2022
Merged

Compile with Ivy #78

merged 11 commits into from
Jan 16, 2022

Conversation

lephyrus
Copy link
Owner

No description provided.

@PascalHonegger
Copy link
Contributor

Hey @lephyrus thanks for maintaining this library! Do you know when this Pull Request is expected to be ready? We're currently holding off on our Angular 13 upgrade because of this.
If we can assist, e.g. by testing a pre-release, we would be happy to do so!

@lephyrus
Copy link
Owner Author

@PascalHonegger First off, the current version is compatible with Angular 13 already, but I guess you know that.

I have not merged/released this mainly because I want to check what the right peer dependencies are (I think partial-ivy works with Angular 12 or 13), and make sure it actually works with those in a minimal project. I should have time this weekend or next week at the latest. Good to know there's some interest!

@tuuling
Copy link

tuuling commented Jan 4, 2022

Or do like ngx-translate did their versions - have one version for ivy only?: v 5.x would be Angular 13 and up?
https://github.com/ngx-translate/core#installation.

And thanks for this package. Doing gods work here!

@lephyrus lephyrus merged commit 38faaec into master Jan 16, 2022
@lephyrus
Copy link
Owner Author

@tuuling That's what I ended up doing. And thanks - glad to see the library is still useful for others too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants